Add ability to configure replicas for services

[martinjt]

This PR adds 2 new settings to the values.yaml

• default.replicas
  This will configure how many replicas of each of the services should be create
• components.<service>.replicaOverride
  This will override the specific service's replicas from the default.

In the supplied values.yaml the default.replicas value is set to 1 so that it doesn't change for existing users. In addition there are specific services that I didn't think should be automatically scaled based on this setting, for these I've added a replicasOverride to their section to keep it at 1, users can obviously override these as they see fit. These are:

• Redis
• Postgres
• Kafka
• Load generator

I'm sure I need to update some change logs, but I'm not sure where, so any guidance would be appreciated.

[TylerHelmuth]

@martinjt looks great. Please update the README with the new values. Also, bump the chart's minor version and run make generate-examples CHARTS=opentelmetry-demo

[martinjt]

Thanks @TylerHelmuth are there any other stateful services that I missed in the replicasOverride?

[TylerHelmuth]

I'd like @puckpuck opinion, buy maybe featureflagService and frontendProxy.

[martinjt]

The Feature Flag service has a postgres database, so I figured that was ok, and I'd assumed the proxy wasn't stateful.

[puckpuck]

What use case would someone set default.replicas to not be 1? Should this even be specified as a default to start with? I think it makes sense to want to scale up specific components, and perhaps this should be just specified at the components level only.

[martinjt]

The idea is to scale up all the services at once, and make that easier for the scenario of just "we want more load". which makes it easier than adding an entry for each of them. Also when/if new components are added, they'll immediately get the replicas.

[martinjt]

Sorry, yes, this was in relation to the question about example charts changing on every release. Want me to PR the removal?

…

On Mon, 14 Aug 2023, 16:57 Tyler Helmuth, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In strip-helm-chart-version.sh <#852 (comment)> : > @@ -0,0 +1,3 @@ +#!/bin/sh + +sed '/helm.sh\/chart/d' <&0 Is this something from local developement? Let's remove it. — Reply to this email directly, view it on GitHub <#852 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM66AY7WMPUH3YT3QFLQZLXVJDHXANCNFSM6AAAAAA3J7UB3Y> . You are receiving this because you were mentioned.Message ID: <open-telemetry/opentelemetry-helm-charts/pull/852/review/1577162134@ github.com>

[TylerHelmuth]

@martinjt we don't need the script in this PR. If you want to discuss examples in an issue thats fine.

For handling merge conflicts between chart.yaml and the examples I find the best solution is the accept the incoming chart.yaml change, modify the version appropriately, and run make generate-examples CHARTS=opentelemetry-demo. This will overwrite all the example merge conflicts and make them accurate.

[martinjt]

I know we don't need it, it was a mistake, I was discussing that script in slack. I was asking whether you'd like me to PR the removal or whether it would be quicker for you to remove it as its not part of this PR.

[martinjt]

No idea what's going on with that failure, it looks fine, I ran the generate-examples and committed them. Any ideas @puckpuck ?

[TylerHelmuth]

@martinjt it looks like you need to update your helm dependencies and then regenerate the examples. This is happening bc we bumped the helm chart dependencies in a previous merge. I believe all you need to do is run helm repo update and then regenerate the examples, but you might have to run helm dependency build ./charts/opentelemetry-demo.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[TylerHelmuth]

@martinjt looks like you've had a bad merge maybe? Please undo the changes to ./charts/opentelemetry-collector and ./charts/opentelemetry-operator. When re-rendering the demo examples use make generate-examples CHARTS=opentelemetry-demo so that only the demo examples are rendered.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.