exclude file logs where we have otlp logs #945
Conversation
zeitlinger
force-pushed
the
exclude-duplicate-logs
branch
from
5c91e77 to
bb8887f
Compare
| filelog: | ||
| exclude: | ||
| - '/var/log/pods/*-otelcol*/opentelemetry-collector/*.log' | ||
| # logs are sent as OTLP, so we filter out the file logs |
There was a problem hiding this comment.
@puckpuck this sounds like a bug with the demo. Is the demo purposefully emitting the logs both as otlp and stdout?
There was a problem hiding this comment.
I thought this is the intended behavior - but I didn't see a definitive answer in https://opentelemetry.io/docs/specs/otel/logs/
There was a problem hiding this comment.
@zeitlinger are you adding logs to the demo yourself? I don't believe the demo does logs over otlp in 1.6
There was a problem hiding this comment.
I have enabled the flag for jvm (adservice, frauddetectionservice), but not for the others (recommendationservice/python, cartservice/dotnet, quoteservice/php)
There was a problem hiding this comment.
I would actually propose to add the java flag to enable logging as well - it will be enabled by default with 2.0 (of the java agent)
There was a problem hiding this comment.
The demo has started to add pieces to support logging, but it isn't complete yet. Any logging that services do is likely some defaults from an SDK that is not yet configured.
|
pls run |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@JaredTan95 can you have another look? |
|
I have a question about this, I didn't seem to see the configuration about collection logs in |
I've excluded logs for applications that are double reported - once for otlp logs and once for logs from the filelog receiver in the collector. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
the duplicate logs are quite confusing