enhance comments & test cmd log msg

open-telemetry · Sep 18, 2024 · 966aee6 · 966aee6
1 parent 586f780
commit 966aee6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.../java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java b/.../java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java
@@ -112,7 +112,7 @@ void endToEndTest() {
     scraper =
         createScraperContainer(otlpEndpoint, getTargetSystem(), null, "target_system", JMX_PORT);
     logger.info(
-        "starting scraper with JVM arguments : {}", String.join(" ", scraper.getCommandParts()));
+        "starting scraper with command: {}", String.join(" ", scraper.getCommandParts()));
 
     scraper.start();
 

diff --git a/jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/client/JmxRemoteClient.java b/jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/client/JmxRemoteClient.java
@@ -86,6 +86,7 @@ public JMXConnector connect() throws IOException {
 
     try {
       // Not all supported versions of Java contain this Provider
+      // Also it might not be accessible due to java.security.sasl module not accessible
       Class<?> klass = Class.forName("com.sun.security.sasl.Provider");
       Provider provider = (Provider) klass.getDeclaredConstructor().newInstance();
       Security.addProvider(provider);