post-review: move factory creation

open-telemetry · Sep 25, 2024 · bb74e6e · bb74e6e
1 parent 2d24b22
commit bb74e6e
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/jmx-scraper/src/test/java/io/opentelemetry/contrib/jmxscraper/JmxScraperTest.java b/jmx-scraper/src/test/java/io/opentelemetry/contrib/jmxscraper/JmxScraperTest.java
@@ -24,21 +24,19 @@ class JmxScraperTest {
  void shouldThrowExceptionWhenInvalidCommandLineArgsProvided() {
  // Given
  List<String> emptyArgs = Collections.singletonList("-nonExistentOption");
- JmxScraperConfigFactory configFactoryMock = mock(JmxScraperConfigFactory.class);
 
  // When and Then
- assertThatThrownBy(() -> JmxScraper.createConfigFromArgs(emptyArgs, configFactoryMock))
+ assertThatThrownBy(() -> JmxScraper.createConfigFromArgs(emptyArgs))
  .isInstanceOf(ArgumentsParsingException.class);
  }
 
  @Test
  void shouldThrowExceptionWhenTooManyCommandLineArgsProvided() {
  // Given
  List<String> args = Arrays.asList("-config", "path", "-nonExistentOption");
- JmxScraperConfigFactory configFactoryMock = mock(JmxScraperConfigFactory.class);
 
  // When and Then
- assertThatThrownBy(() -> JmxScraper.createConfigFromArgs(args, configFactoryMock))
+ assertThatThrownBy(() -> JmxScraper.createConfigFromArgs(args))
  .isInstanceOf(ArgumentsParsingException.class);
  }
 
@@ -49,10 +47,9 @@ void shouldCreateConfig_propertiesLoadedFromFile()
  String filePath =
  ClassLoader.getSystemClassLoader().getResource("validConfig.properties").getPath();
  List<String> args = Arrays.asList("-config", filePath);
- JmxScraperConfigFactory configFactory = new JmxScraperConfigFactory();
 
  // When
- JmxScraperConfig config = JmxScraper.createConfigFromArgs(args, configFactory);
+ JmxScraperConfig config = JmxScraper.createConfigFromArgs(args);
 
  // Then
  assertThat(config).isNotNull();
@@ -67,10 +64,9 @@ void shouldCreateConfig_propertiesLoadedFromStdIn()
  // Given
  System.setIn(stream);
  List<String> args = Arrays.asList("-config", "-");
- JmxScraperConfigFactory configFactory = new JmxScraperConfigFactory();
 
  // When
- JmxScraperConfig config = JmxScraper.createConfigFromArgs(args, configFactory);
+ JmxScraperConfig config = JmxScraper.createConfigFromArgs(args);
 
  // Then
  assertThat(config).isNotNull();