Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a JFR recording may throw an Exception #1410

Closed
dsgrieve opened this issue Aug 12, 2024 · 2 comments
Closed

Closing a JFR recording may throw an Exception #1410

dsgrieve opened this issue Aug 12, 2024 · 2 comments
Assignees

Comments

@dsgrieve
Copy link
Contributor

Component(s)

jfr-connection

What happened?

Description

Calling the Recording#close() method may throw an exception if the FlightRecorder MXBean closeRecording function fails.
The behavior of the original microsoft/jfr-streaming code was to swallow the exception. The behavior of the contributed code is different and this has caused a regression in an application that uses this module.

Steps to Reproduce

Expected Result

The close() method on a Recording should not throw an exception.

Actual Result

Component version

1.37.0

Log output

No response

Additional context

No response

@dsgrieve
Copy link
Contributor Author

PR #1412

@trask
Copy link
Member

trask commented Sep 23, 2024

Resolved by #1412

@trask trask closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants