jfr-connection: Recording close should not throw exception #1412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recording close method would throw an exception if the FlightRecorderConnection closeRecording method threw an exception. This is a regression from the microsoft/jfr-streaming code that was contributed.
Existing Issue(s):
Closing a JFR recording may throw an Exception #1410
Testing:
Existing tests were examined and no changes were necessary.
Documentation:
No changes to documentation were needed. However, several methods in FlightRecorderMXBeanConnection stated that the method was not available in Java 8. The javadoc for these methods was changed to more correctly state that the command is not available through the Diagnostic Command MBean.
Outstanding items:
None.