Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jfr-connection: Recording close should not throw exception #1412

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

dsgrieve
Copy link
Contributor

Description:
Recording close method would throw an exception if the FlightRecorderConnection closeRecording method threw an exception. This is a regression from the microsoft/jfr-streaming code that was contributed.

Existing Issue(s):

Closing a JFR recording may throw an Exception #1410
Testing:

Existing tests were examined and no changes were necessary.

Documentation:

No changes to documentation were needed. However, several methods in FlightRecorderMXBeanConnection stated that the method was not available in Java 8. The javadoc for these methods was changed to more correctly state that the command is not available through the Diagnostic Command MBean.

Outstanding items:

None.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. Maybe it was just an oversight or a mistake, but it does indeed seem odd that it was swallowing the exception for stopRecording() but not closeRecording(). Thanks!

@trask trask added this to the v1.38.0 milestone Aug 15, 2024
@trask trask merged commit 1942659 into open-telemetry:main Aug 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants