New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved java doc, explicit passing of invalid p-value to root sampler #1053

Merged

trask merged 1 commit into open-telemetry:main from dynatrace-oss-contrib:consistent-parent-based-sampler-improvements

Sep 25, 2023

Contributor

oertl commented Sep 25, 2023

Description:

Fixed Java doc which did not describe what is actually done
Pass explicitly an invalid p-value to the root sampler as the parent p-value must be invalid anyway for root spans


improved java doc, explicit passing of invalid p-value to root sampler

199940d

oertl requested a review from a team

September 25, 2023 07:06

github-actions bot assigned oertl and PeterF778

github-actions bot requested a review from PeterF778

September 25, 2023 07:06

laurit approved these changes

View reviewed changes

PeterF778 approved these changes

View reviewed changes

trask merged commit 105e50c into open-telemetry:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment