-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistent sampler prototypes using 56 bits of randomness #1063
consistent sampler prototypes using 56 bits of randomness #1063
Conversation
...t-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent2/ConsistentSampler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/contrib/sampler/consistent2/ConsistentRateLimitingSampler.java
Outdated
Show resolved
Hide resolved
...t-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent2/ConsistentSampler.java
Outdated
Show resolved
Hide resolved
...pling/src/main/java/io/opentelemetry/contrib/sampler/consistent2/ConsistentSamplingUtil.java
Outdated
Show resolved
Hide resolved
...t-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent2/ConsistentSampler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oertl would we deprecate the old consistent samplers in the future, or is there a long-term need for them? thx
just to confirm my understanding, the |
yes, this is correct |
consistent sampler prototypes using 56 bits of randomness as proposed by
open-telemetry/oteps#235
still requires more unit tests