Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wildfly.yaml to JMX scraper #1531

Merged
merged 26 commits into from
Nov 14, 2024
Merged

Conversation

SylvainJuge
Copy link
Contributor

Description:

  • add wildfly support for jmx scraper with dedicated YAML configuration
  • adds wildfly tests using jboss-client.jar for using HTTP management API
  • fixes support for login/pwd authentication
  • adds a test webapp needed to test wildfly session metrics
  • moves existing test app to dedicated module for simplicity (and making it similar to test webapp)
  • fixes use of plural form in units in wildfly.groovy to fit the stable convention for metric units.

Part of #1362

Notes:

In the original groovy implementation session metrics are not tested, this requires deploying and application to the container, this is not properly tested in the YAML implementation.

In the original groovy implementation the gatherer was run directly from the same docker container probably for simplicity as jboss-client.jar is directly available.
When using two containers, the jar needs to be copied from wildfly container to scraper container and it complicates authentication: login/pwd can be skipped if both processes run on the same host and can access the same filesystem.
Testing here is done using two distinct containers as this setup is a bit more complex and thus likely to fail (doing so here helped me find that we did not handle it properly).

@SylvainJuge SylvainJuge marked this pull request as ready for review November 6, 2024 16:29
@SylvainJuge SylvainJuge requested a review from a team as a code owner November 6, 2024 16:29
@trask trask merged commit 74a3d78 into open-telemetry:main Nov 14, 2024
14 checks passed
@SylvainJuge SylvainJuge deleted the jmx-wildfly branch November 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants