Improve containers startup and increase max duration of test #1612
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsunday
commented
Dec 17, 2024
| @@ -167,7 +167,7 @@ protected final void waitAndAssertMetrics(Consumer<Metric>... assertions) { | |||
| protected void verifyMetrics() { | |||
| MetricsVerifier metricsVerifier = createMetricsVerifier(); | |||
| await() | |||
| .atMost(Duration.ofSeconds(30)) | |||
| .atMost(Duration.ofSeconds(60)) | |||
There was a problem hiding this comment.
[for reviewer] Increase maximum assertions timeout to give tested target more time to stabilize and generate all the metrics
SylvainJuge
approved these changes
Dec 17, 2024
trask
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is not the full fix for flaky integration tests but it should improve their stability. More PRs will come.
Part of fix for #1605
Because some of the metrics may require some more time to be reported. Maximum metrics assertion timeout has been increased to support this scenario. This timeout increase does not impact successful tests duration because such tests end as soon as all assertions are fulfilled.