jmx-scraper replicate and document jmxmp/sasl config #1749
Merged
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrib into scraper-advanced-security
5 tasks
SylvainJuge
commented
Feb 20, 2025
Comment on lines
+18
to
+23
| maven { | ||
| setUrl("https://repo.terracotta.org/maven2") | ||
| content { | ||
| includeGroupByRegex("""org\.terracotta.*""") | ||
| } | ||
| } |
There was a problem hiding this comment.
[for reviewer] moving this here allows to avoid duplication between gatherer and scraper to access this repository.
robsunday
approved these changes
Feb 21, 2025
trask
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1681
The JMX Gatherer provides options to use the JMXMP and SASL authentication options, which allow to extend the simple login/pwd authentication and delegate to a "real" authentication system like LDAP. While that sounds simple with words is more challenging in practice because this is something sparsely documented and the JMXMP client and server implementation is not even shipped with the JDK.
I was not able to reproduce a working client and server for end-to-end integration test, so for now it means it will be only documented and provided as-is. The current JMX Gatherer implementation is not tested either, and we can adjust the implementation and hopefully enable testing through user feedback.
In summary this PR contains:
The implementation of those config options is already included and had been copied as-is from gatherer code.