Implement GC duration metric #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
breedx-splk,
jack-berg and
kittylyst
jack-berg
reviewed
Dec 20, 2022
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/HandlerRegistry.java
Outdated
Show resolved
Hide resolved
| @@ -50,6 +55,7 @@ static HandlerRegistry createDefault(MeterProvider meterProvider) { | |||
| var seen = new HashSet<String>(); | |||
| for (var bean : ManagementFactory.getGarbageCollectorMXBeans()) { | |||
| var name = bean.getName(); | |||
| garbageCollectors.add(name); | |||
There was a problem hiding this comment.
It's pretty tricky to tell which handlers get added in response to which garbage collectors. How about just a switch statement with cases for each known garbage collector bean name, where each case explicitly registers its required handlers?
There was a problem hiding this comment.
I think that's a good idea. Implemented suggestion.
jack-berg
reviewed
Dec 22, 2022
...pentelemetry/contrib/jfr/metrics/internal/GarbageCollection/OldGarbageCollectionHandler.java
Outdated
Show resolved
Hide resolved
...pentelemetry/contrib/jfr/metrics/internal/GarbageCollection/OldGarbageCollectionHandler.java
Outdated
Show resolved
Hide resolved
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/HandlerRegistry.java
Outdated
Show resolved
Hide resolved
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/HandlerRegistry.java
Show resolved
Hide resolved
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/HandlerRegistry.java
Outdated
Show resolved
Hide resolved
| @@ -72,7 +86,8 @@ static HandlerRegistry createDefault(MeterProvider meterProvider) { | |||
| new ContainerConfigurationHandler(), | |||
| new LongLockHandler(grouper), | |||
| new ThreadCountHandler(), | |||
| new ClassesLoadedHandler()); | |||
| new ClassesLoadedHandler(), | |||
| new OldGarbageCollectionHandler(garbageCollectors)); | |||
There was a problem hiding this comment.
These could be added in the switch statement as well. Instead of passing the set of garbageCollectors you could pass the name of the garbage collector as a constructor argument.
There was a problem hiding this comment.
This is a good idea. It also allows us to get rid of the set caching all the GC types. Done!
jack-berg
reviewed
Dec 22, 2022
...pentelemetry/contrib/jfr/metrics/internal/GarbageCollection/OldGarbageCollectionHandler.java
Outdated
Show resolved
Hide resolved
...ntelemetry/contrib/jfr/metrics/internal/GarbageCollection/YoungGarbageCollectionHandler.java
Outdated
Show resolved
Hide resolved
…cs/internal/GarbageCollection/OldGarbageCollectionHandler.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…cs/internal/GarbageCollection/YoungGarbageCollectionHandler.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
jack-berg
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds changes that implement the metric
process.runtime.jvm.gc.duration.This was a part of a larger PR here: #644.
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/internal/Constants.javahas been kept the same as it was in the larger PR because it's used in all of the smaller constituent PRs. This will hopefully also avoid some conflicts as the PRs are sequentially merged. As a result, there are some constants that are defined, but not used in this PR.Testing:
Tests were added but they don't have great coverage. In the future we need to devise a reliable way to test each GC. Currently, I'm not sure of a way to change GCs at runtime in order to test them all. I'm also uncertain of how to reliably force young gen GC and old gen GC. As a result, the test added in this PR basically just invokes "some" GC and ensures that the resulting metric has data that is expected.