Skip to content

Commit

Permalink
Fix vaadin 14 test failures (#7856)
Browse files Browse the repository at this point in the history
Resolves
#7859
Resolves
#7855
Resolves
#7854
Apparently default node version was change to 18 for github actions. I
wasn't able to reproduce the failure, nor find anything in the test
output that would help to pinpoint the exact cause of the failure.
Changing the node version to 16 seems to get vaadin 14 tests passing
again.
  • Loading branch information
laurit authored Feb 20, 2023
1 parent b139e1d commit 0351cfb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/build-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ jobs:
distribution: temurin
java-version: 17

# vaadin 14 tests fail with node 18
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 16

# vaadin tests use pnpm
- name: Cache pnpm modules
uses: actions/cache@v3
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/reusable-test-latest-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ jobs:
distribution: temurin
java-version: 17

# vaadin 14 tests fail with node 18
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 16

# vaadin tests use pnpm
- name: Cache pnpm modules
uses: actions/cache@v3
Expand Down

0 comments on commit 0351cfb

Please sign in to comment.