Skip to content

Commit

Permalink
Add Java 18 smoke test images (#4905)
Browse files Browse the repository at this point in the history
* Add Java 18 smoke test images

* alpine images only exist for recent jdks

* Fix servlet image build

* Revert for liberty
  • Loading branch information
trask authored Dec 15, 2021
1 parent b01efec commit bd0ff33
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 14 deletions.
1 change: 1 addition & 0 deletions .github/workflows/pr-smoke-test-grpc-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ jobs:
./gradlew jibDockerBuild -PtargetJDK=8 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain
working-directory: smoke-tests/images/grpc
1 change: 1 addition & 0 deletions .github/workflows/pr-smoke-test-quarkus-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ jobs:
run: |
./gradlew jibDockerBuild -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain
working-directory: smoke-tests/images/quarkus
1 change: 1 addition & 0 deletions .github/workflows/pr-smoke-test-spring-boot-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ jobs:
./gradlew jibDockerBuild -PtargetJDK=8 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain
./gradlew jibDockerBuild -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain
working-directory: smoke-tests/images/spring-boot
1 change: 1 addition & 0 deletions .github/workflows/publish-smoke-test-grpc-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
./gradlew jib -PtargetJDK=8 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
working-directory: smoke-tests/images/grpc

issue:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish-smoke-test-quarkus-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
echo "Pushing to tag $TAG"
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
working-directory: smoke-tests/images/quarkus

issue:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
./gradlew jib -PtargetJDK=8 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
./gradlew jib -PtargetJDK=18 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG
working-directory: smoke-tests/images/spring-boot

issue:
Expand Down
2 changes: 1 addition & 1 deletion smoke-tests/images/grpc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ def targetJDK = project.hasProperty("targetJDK") ? project.targetJDK : 11
def tag = findProperty("tag") ?: new Date().format("yyyyMMdd.HHmmSS")

jib {
from.image = "bellsoft/liberica-openjdk-alpine:$targetJDK"
from.image = "openjdk:$targetJDK"
to.image = "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-grpc:jdk$targetJDK-$tag"
}
2 changes: 1 addition & 1 deletion smoke-tests/images/play/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def targetJDK = project.hasProperty("targetJDK") ? project.targetJDK : 11
def tag = findProperty("tag") ?: new Date().format("yyyyMMdd.HHmmSS")

jib {
from.image = "bellsoft/liberica-openjdk-alpine:$targetJDK"
from.image = "openjdk:$targetJDK"
to.image = "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-play:jdk$targetJDK-$tag"
container.mainClass = "play.core.server.ProdServerStart"
}
2 changes: 1 addition & 1 deletion smoke-tests/images/quarkus/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def targetJDK = project.hasProperty("targetJDK") ? project.targetJDK : 11
def tag = findProperty("tag") ?: new Date().format("yyyyMMdd.HHmmSS")

jib {
from.image = "bellsoft/liberica-openjdk-alpine:$targetJDK"
from.image = "openjdk:$targetJDK"
to.image = "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-quarkus:jdk$targetJDK-$tag"
container {
mainClass = 'bogus' // to suppress Jib warning about missing main class
Expand Down
25 changes: 15 additions & 10 deletions smoke-tests/images/servlet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,17 @@ tasks.create("pushMatrix", DockerPushImage) {
// Dockerfile name, args key passes raw arguments to docker build
def targets = [
"jetty" : [
[version: ["9.4.39"], vm: ["hotspot"], jdk: ["8", "11", "17"], args: [sourceVersion: "9.4.39.v20210325"]],
[version: ["9.4.39"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"], args: [sourceVersion: "9.4.39.v20210325"]],
[version: ["9.4.39"], vm: ["openj9"], jdk: ["8", "11", "16"], args: [sourceVersion: "9.4.39.v20210325"]],
[version: ["10.0.7"], vm: ["hotspot"], jdk: ["11", "17"], args: [sourceVersion: "10.0.7"]],
[version: ["10.0.7"], vm: ["hotspot"], jdk: ["11", "17", "18"], args: [sourceVersion: "10.0.7"]],
[version: ["10.0.7"], vm: ["openj9"], jdk: ["11", "16"], args: [sourceVersion: "10.0.7"]],
[version: ["11.0.7"], vm: ["hotspot"], jdk: ["11", "17"], args: [sourceVersion: "11.0.7"], war: "servlet-5.0"],
[version: ["11.0.7"], vm: ["hotspot"], jdk: ["11", "17", "18"], args: [sourceVersion: "11.0.7"], war: "servlet-5.0"],
[version: ["11.0.7"], vm: ["openj9"], jdk: ["11", "16"], args: [sourceVersion: "11.0.7"], war: "servlet-5.0"]
],
"liberty" : [
// running configure.sh is failing while building the image with Java 17
[version: ["20.0.0.12"], vm: ["hotspot", "openj9"], jdk: ["8", "11", "16"], args: [release: "2020-11-11_0736"]],
// running configure.sh is failing while building the image with Java 18
[version: ["21.0.0.10"], vm: ["hotspot"], jdk: ["8", "11", "17"], args: [release: "2021-09-20_1900"]],
[version: ["21.0.0.10"], vm: ["openj9"], jdk: ["8", "11", "16"], args: [release: "2021-09-20_1900"]]
],
Expand All @@ -49,19 +50,19 @@ def targets = [
],
"tomcat" : [
[version: ["7.0.109"], vm: ["hotspot", "openj9"], jdk: ["8"], args: [majorVersion: "7"]],
[version: ["8.5.72"], vm: ["hotspot"], jdk: ["8", "11", "17"], args: [majorVersion: "8"]],
[version: ["8.5.72"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"], args: [majorVersion: "8"]],
[version: ["8.5.72"], vm: ["openj9"], jdk: ["8", "11"], args: [majorVersion: "8"]],
[version: ["9.0.54"], vm: ["hotspot"], jdk: ["8", "11", "17"], args: [majorVersion: "9"]],
[version: ["9.0.54"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"], args: [majorVersion: "9"]],
[version: ["9.0.54"], vm: ["openj9"], jdk: ["8", "11"], args: [majorVersion: "9"]],
[version: ["10.0.12"], vm: ["hotspot"], jdk: ["8", "11", "17"], args: [majorVersion: "10"], war: "servlet-5.0"],
[version: ["10.0.12"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"], args: [majorVersion: "10"], war: "servlet-5.0"],
[version: ["10.0.12"], vm: ["openj9"], jdk: ["8", "11"], args: [majorVersion: "10"], war: "servlet-5.0"]
],
"tomee" : [
[version: ["7.0.9"], vm: ["hotspot", "openj9"], jdk: ["8"]],
[version: ["7.1.4"], vm: ["hotspot", "openj9"], jdk: ["8"]],
[version: ["8.0.8"], vm: ["hotspot"], jdk: ["8", "11", "17"]],
[version: ["8.0.8"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"]],
[version: ["8.0.8"], vm: ["openj9"], jdk: ["8", "11", "16"]],
[version: ["9.0.0-M7"], vm: ["hotspot"], jdk: ["8", "11", "17"], war: "servlet-5.0"],
[version: ["9.0.0-M7"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"], war: "servlet-5.0"],
[version: ["9.0.0-M7"], vm: ["openj9"], jdk: ["8", "11", "16"], war: "servlet-5.0"]
],
"websphere": [
Expand All @@ -71,7 +72,7 @@ def targets = [
],
"wildfly" : [
[version: ["13.0.0.Final"], vm: ["hotspot", "openj9"], jdk: ["8"]],
[version: ["17.0.1.Final", "21.0.0.Final", "25.0.1.Final"], vm: ["hotspot"], jdk: ["8", "11", "17"]],
[version: ["17.0.1.Final", "21.0.0.Final", "25.0.1.Final"], vm: ["hotspot"], jdk: ["8", "11", "17", "18"]],
[version: ["17.0.1.Final", "21.0.0.Final", "25.0.1.Final"], vm: ["openj9"], jdk: ["8", "11", "16"]]
]
]
Expand Down Expand Up @@ -125,7 +126,11 @@ def configureImage(Task parentTask, server, dockerfile, version, vm, jdk, warPro

def jdkImage
if (vm == "hotspot") {
jdkImage = "eclipse-temurin:${jdk}"
if (jdk == "18") {
jdkImage = "openjdk:${jdk}"
} else {
jdkImage = "eclipse-temurin:${jdk}"
}
} else if (vm == "openj9") {
jdkImage = "adoptopenjdk:${jdk}-openj9"
} else {
Expand Down
2 changes: 1 addition & 1 deletion smoke-tests/images/spring-boot/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def targetJDK = project.hasProperty("targetJDK") ? project.targetJDK : 11
def tag = findProperty("tag") ?: new Date().format("yyyyMMdd.HHmmSS")

jib {
from.image = "bellsoft/liberica-openjdk-alpine:$targetJDK"
from.image = "openjdk:$targetJDK"
to.image = "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-spring-boot:jdk$targetJDK-$tag"
container.ports = ["8080"]
}

0 comments on commit bd0ff33

Please sign in to comment.