Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muzzle can allow declaring code blocks as requiring certain classes #2556

Closed
anuraaga opened this issue Mar 11, 2021 · 0 comments · Fixed by #7289
Closed

Muzzle can allow declaring code blocks as requiring certain classes #2556

anuraaga opened this issue Mar 11, 2021 · 0 comments · Fixed by #7289
Labels
enhancement New feature or request

Comments

@anuraaga
Copy link
Contributor

The topic has come up a bit in AWS SDK instrumentation, but it would be nice if Muzzle could have a feature very similar to spring boot, something like marking a method as ConditionalOnClass(blah). The instrumentation still applies even if the class, or any references within the annotated method tree, isn't there.
@anuraaga anuraaga added the enhancement New feature or request label Mar 11, 2021
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Dec 20, 2021
Closed
@mateuszrzeszutek mateuszrzeszutek linked a pull request Dec 1, 2022 that will close this issue
Allow disabling muzzle checks for specific methods #7289
Merged
@laurit laurit mentioned this issue Dec 2, 2022
Merged
trask added a commit that referenced this issue Dec 12, 2022
@laurit @trask
Allow disabling muzzle checks for specific methods (#7289)
f3a21e8 
Resolves
#2556

#7265
made me wonder whether it would help when we could sometimes skip muzzle
checks.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow disabling muzzle checks for specific methods laurit/opentelemetry-java-instrumentation
1 participant
@anuraaga