Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FooTracing to FooInstrumentation or FooInstrumenter #3156

Closed
anuraaga opened this issue Jun 1, 2021 · 4 comments · Fixed by #5624
Closed

Rename FooTracing to FooInstrumentation or FooInstrumenter #3156

anuraaga opened this issue Jun 1, 2021 · 4 comments · Fixed by #5624
Labels
enhancement New feature or request

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Jun 1, 2021

Now that it's not just tracing we need to rename our library instrumentations. Which name is better? I lean towards FooInstrumentation since users don't interact with Instrumenter.
@anuraaga anuraaga added the enhancement New feature or request label Jun 1, 2021
@anuraaga
Copy link
Contributor Author

anuraaga commented Jun 1, 2021 •
edited
Loading

It was sort of nice how we didn't have overlap with naming in the javaagent modules though, where we use FooInstrumentation as a TypeInstrumentation. Don't think it's a deal-breaker though.

@anuraaga anuraaga changed the title Rename to FooInstrumentation or FooInstrumenter Rename FooTracing to FooInstrumentation or FooInstrumenter Jun 1, 2021
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Sep 28, 2021
Closed
@iNikem
Copy link
Contributor

iNikem commented Oct 11, 2021

Will be effectively implemented by #2713

@iNikem iNikem closed this as completed Oct 11, 2021
@mateuszrzeszutek
Copy link
Member

Will be effectively implemented by #2713

Hm, I don't think it will - this issue is about deciding whether to rename the library instrumentation classes e.g. OkHttpTracing to OkHttpInstrumentation/OkHttpTelemetry. It's not directly connected to #2713 (we'd have to rename already existing library classes too)

@anuraaga
Copy link
Contributor Author

Thanks @mateuszrzeszutek. By the way, after hearing it I'm liking the FooTelemetry naming scheme for the symmetry with OpenTelemetry.

@mateuszrzeszutek mateuszrzeszutek linked a pull request Mar 18, 2022 that will close this issue
Rename library entrypoints to Telemetry #5624
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename library entrypoints to Telemetry anuraaga/opentelemetry-java-instrumentation
3 participants
@anuraaga @iNikem @mateuszrzeszutek