Rename library entrypoints to Telemetry #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Mar 18, 2022
Comment on lines
25
to
29
| GraphQLTelemetry tracing = | ||
| GraphQLTelemetry.builder(testing.getOpenTelemetry()) | ||
| .setCaptureExperimentalSpanAttributes(true) | ||
| .build(); | ||
| builder.instrumentation(tracing.newInstrumentation()); |
There was a problem hiding this comment.
Suggested change
| GraphQLTelemetry tracing = | |
| GraphQLTelemetry.builder(testing.getOpenTelemetry()) | |
| .setCaptureExperimentalSpanAttributes(true) | |
| .build(); | |
| builder.instrumentation(tracing.newInstrumentation()); | |
| GraphQLTelemetry telemetry = | |
| GraphQLTelemetry.builder(testing.getOpenTelemetry()) | |
| .setCaptureExperimentalSpanAttributes(true) | |
| .build(); | |
| builder.instrumentation(telemetry.newInstrumentation()); |
| @@ -20,8 +20,8 @@ | |||
| private static final boolean CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES = | |||
| Config.get().getBoolean("otel.instrumentation.graphql.experimental-span-attributes", false); | |||
|
|
|||
| private static final GraphQLTracing TRACING = | |||
| GraphQLTracing.builder(GlobalOpenTelemetry.get()) | |||
| private static final GraphQLTelemetry TRACING = | |||
Comment on lines
22
to
25
| ArmeriaTelemetry tracing = ArmeriaTelemetry.create(GlobalOpenTelemetry.get()); | ||
|
|
||
| CLIENT_DECORATOR = tracing.newClientDecorator(); | ||
| SERVER_DECORATOR = tracing.newServiceDecorator(); |
There was a problem hiding this comment.
Suggested change
| ArmeriaTelemetry tracing = ArmeriaTelemetry.create(GlobalOpenTelemetry.get()); | |
| CLIENT_DECORATOR = tracing.newClientDecorator(); | |
| SERVER_DECORATOR = tracing.newServiceDecorator(); | |
| ArmeriaTelemetry telemetry = ArmeriaTelemetry.create(GlobalOpenTelemetry.get()); | |
| CLIENT_DECORATOR = telemetry.newClientDecorator(); | |
| SERVER_DECORATOR = telemetry.newServiceDecorator(); |
| @@ -26,8 +26,8 @@ | |||
| boolean experimentalSpanAttributes = | |||
| Config.get().getBoolean("otel.instrumentation.grpc.experimental-span-attributes", false); | |||
|
|
|||
| GrpcTracing tracing = | |||
| GrpcTracing.builder(GlobalOpenTelemetry.get()) | |||
| GrpcTelemetry tracing = | |||
…nstrumentation into telemetry-entry
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Rename library entrypoints to Telemetry * Renames
trask
pushed a commit
that referenced
this pull request
Jan 15, 2023
for okhttp-3.0 instrumentation, the README uses `OkHttpTracing`: ```java import io.opentelemetry.instrumentation.okhttp.v3_0.OkHttpTracing; ... return OkHttpTracing.builder(openTelemetry).build().newCallFactory(createClient()); ``` #5624 changed `OkHttpTracing` to `OkHttpTelemetry` but the docs still show the previous value which no longer works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been wanting to solve our long standing issue of naming our entrypoints Tracing even though they are more than tracing since we should write more examples for library instrumentation and would be good to have more stable APIs. I think we liked the idea Telemetry when discussing a while back.