Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(okhttp): fix class name in README #7578

Merged
merged 1 commit into from
Jan 15, 2023
Merged

docs(okhttp): fix class name in README #7578

merged 1 commit into from
Jan 15, 2023

Conversation

blumamir
Copy link
Member

for okhttp-3.0 instrumentation, the README uses OkHttpTracing:

import io.opentelemetry.instrumentation.okhttp.v3_0.OkHttpTracing;
...
return OkHttpTracing.builder(openTelemetry).build().newCallFactory(createClient());

#5624 changed OkHttpTracing to OkHttpTelemetry but the docs still show the previous value which no longer works

@blumamir blumamir requested a review from a team January 15, 2023 08:27
@github-actions github-actions bot requested a review from theletterf January 15, 2023 08:27
trask
trask approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@trask trask merged commit 911b3b5 into open-telemetry:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blumamir @trask