Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the Micronaut framework? #3424

Closed
bixu opened this issue Jun 28, 2021 · 11 comments
Closed

Support for the Micronaut framework? #3424

bixu opened this issue Jun 28, 2021 · 11 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@bixu
Copy link

bixu commented Jun 28, 2021

Hi all, has there been consideration of adding support for the Micronaut "cloud-native" framework?

@bixu bixu added the enhancement New feature or request label Jun 28, 2021
@mateuszrzeszutek
Copy link
Member

Hey @bixu ,
We probably won't have the capacity to implement this ourselves, but we'll gladly accept external contributions.

@mateuszrzeszutek mateuszrzeszutek added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jun 28, 2021
@donbeave
Copy link
Contributor

Hello, @bixu!

I'm working on micronaut-opentelemetry module, which uses some libraries from opentelemetry-java-instrumentation project. That's why I'm implementing OpenTelemetry JDBC instrumentation library: #3367, which will allow to use it in GraalVM images.

Please follow this issue regarding the official OpenTelemetry module in Micronaut 3.0: https://github.com/micronaut-projects/micronaut-core/issues/5138.

@tkhoiwal
Copy link

tkhoiwal commented Oct 7, 2021

I tested simple helloworld as well as two tier micronaut applications with OT agent. I see basic support is already present due to underlying Netty support by OT agent. What are we looking specifically with micronaut support?

@donbeave
Copy link
Contributor

donbeave commented Oct 7, 2021

@tkhoiwal the most interesting part of Micronaut is the ability to build the app with GraalVM native image feature. For such use case java agent will not work, that's why I have started to working on micronaut-opentelemetry module: https://github.com/expatiat/micronaut-opentelemetry

@jkwatson
Copy link
Contributor

jkwatson commented Oct 7, 2021

@tkhoiwal the most interesting part of Micronaut is the ability to build the app with GraalVM native image feature. For such use case java agent will not work, that's why I have started to working on micronaut-opentelemetry module: https://github.com/expatiat/micronaut-opentelemetry

Just peeked at that repo for a brief moment and it looks like you have duplicated instrumentation for grpc. Any reason why not to just use the grpc library instrumentation maintainer here as a dependency?

@donbeave
Copy link
Contributor

donbeave commented Oct 7, 2021

The main idea for micronaut-opentelemetry is to reuse as much as possible from https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation, that's one of the reasons why I have implemented JDBC instrumentation library: #3367.

@jkwatson
Copy link
Contributor

jkwatson commented Oct 7, 2021

@jkwatson hm, actually I'm using io.opentelemetry.instrumentation:opentelemetry-grpc-1.6. If you check the server and client tracing both using this library:

oh, my apologies, I saw the packages and made assumptions. You're just providing micronaut configuration. 👍🏽

@tkhoiwal
Copy link

tkhoiwal commented Oct 8, 2021

@tkhoiwal the most interesting part of Micronaut is the ability to build the app with GraalVM native image feature. For such use case java agent will not work, that's why I have started to working on micronaut-opentelemetry module: https://github.com/expatiat/micronaut-opentelemetry

Thanks @donbeave for details of the usecase.

@donbeave
Copy link
Contributor

donbeave commented Jun 3, 2022

Micronaut has added OpenTelemetry support in its micronaut-tracing module, it's available as a SNAPSHOT build for now: micronaut-projects/micronaut-tracing#65 (comment)

@mateuszrzeszutek
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
Development

No branches or pull requests

6 participants