Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Http*Getter depend on Net*Getter and deprecate Net*Getters #9013

Closed
mateuszrzeszutek opened this issue Jul 21, 2023 · 0 comments · Fixed by #9165
Closed

Make Http*Getter depend on Net*Getter and deprecate Net*Getters #9013

mateuszrzeszutek opened this issue Jul 21, 2023 · 0 comments · Fixed by #9165
Assignees
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

We'd like the HTTP getters to extend the getters representing semconvs HTTP depends on. E.g. this is what HttpClientAttributesGetter should look like:

public interface HttpClientAttributesGetter<REQUEST, RESPONSE>
    extends HttpCommonAttributesGetter<REQUEST, RESPONSE>,
    NetClientAttributesGetter<REQUEST, RESPONSE>, // deprecated: to be removed in 2.0
    NetworkAttributesGetter<REQUEST, RESPONSE>,
    ServerAttributesGetter<REQUEST, RESPONSE>

At the same time, we'll deprecate Net*AttributesGetter and all the methods in HTTP semconv that depend on them: create(Http*Getter, Net*Getter) and builder(Http*Getter, Net*Getter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant