Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NetClientAttributesExtractor #9165

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #9013

#9156 needs to be merged first

@mateuszrzeszutek mateuszrzeszutek changed the title Deprecate net client attributes extractor Deprecate NetClientAttributesExtractor Aug 9, 2023
@mateuszrzeszutek mateuszrzeszutek force-pushed the deprecate-NetClientAttributesExtractor branch 3 times, most recently from f766aa1 to 8073d0d Compare August 9, 2023 15:03
@mateuszrzeszutek mateuszrzeszutek force-pushed the deprecate-NetClientAttributesExtractor branch from 8073d0d to f1feb68 Compare August 11, 2023 13:05
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review August 11, 2023 13:05
@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 11, 2023 13:06
} else if (remoteAddress instanceof Inet6Address) {
return "ipv6";
}
return null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mateuszrzeszutek mateuszrzeszutek merged commit 65451b6 into open-telemetry:main Aug 16, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the deprecate-NetClientAttributesExtractor branch August 16, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Http*Getter depend on Net*Getter and deprecate Net*Getters
2 participants