Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host.id resource provider #10627

Merged
merged 14 commits into from
Mar 12, 2024
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.instrumentation.resources;

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
import io.opentelemetry.sdk.autoconfigure.spi.internal.ConditionalResourceProvider;
import io.opentelemetry.sdk.resources.Resource;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.nio.charset.StandardCharsets;
import java.nio.file.FileSystems;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.List;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.stream.Collectors;

/** {@link ResourceProvider} for automatically configuring <code>host.id</code>. */
public final class HostIdResourceProvider implements ConditionalResourceProvider {

private static final Logger logger = Logger.getLogger(HostIdResourceProvider.class.getName());

public static final AttributeKey<String> HOST_ID = AttributeKey.stringKey("host.id");
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
public static final String REGISTRY_QUERY =
"reg query HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Cryptography /v MachineGuid";

private final Supplier<OsType> getOsType;

private final Function<Path, List<String>> pathReader;

private final Supplier<ExecResult> queryWindowsRegistry;

enum OsType {
WINDOWS,
LINUX
}

static class ExecResult {
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
int exitCode;
List<String> lines;

public ExecResult(int exitCode, List<String> lines) {
this.exitCode = exitCode;
this.lines = lines;
}
}

public HostIdResourceProvider() {
this(
HostIdResourceProvider::getOsType,
path -> {
try {
return Files.readAllLines(path);
} catch (IOException e) {
throw new IllegalStateException(e);
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
}
},
HostIdResourceProvider::queryWindowsRegistry);
}

// Visible for testing
HostIdResourceProvider(
Supplier<OsType> getOsType,
Function<Path, List<String>> pathReader,
Supplier<ExecResult> queryWindowsRegistry) {
this.getOsType = getOsType;
this.pathReader = pathReader;
this.queryWindowsRegistry = queryWindowsRegistry;
}

@Override
public Resource createResource(ConfigProperties config) {
OsType osType = getOsType.get();
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
switch (osType) {
case WINDOWS:
return readWindowsGuid();
case LINUX:
return readLinuxMachineId();
}
throw new IllegalStateException("Unsupported OS type: " + osType);
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
}

private Resource readLinuxMachineId() {
Path path = FileSystems.getDefault().getPath("/etc/machine-id");
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
try {
List<String> lines = pathReader.apply(path);
if (lines.isEmpty()) {
logger.warning("Failed to read /etc/machine-id: empty file");
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
return Resource.empty();
}
return Resource.create(Attributes.of(HOST_ID, lines.get(0)));
} catch (RuntimeException e) {
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
logger.log(Level.WARNING, "Failed to read /etc/machine-id", e);
return Resource.empty();
}
}

private static OsType getOsType() {
String osName = System.getProperty("os.name");
return osName != null && osName.startsWith("Windows") ? OsType.WINDOWS : OsType.LINUX;
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
}

private Resource readWindowsGuid() {

zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
try {
ExecResult execResult = queryWindowsRegistry.get();

if (execResult.exitCode != 0) {
logger.warning(
"Failed to read Windows registry. Exit code: "
+ execResult.exitCode
+ " Output: "
+ String.join("\n", execResult.lines));
return Resource.empty();
}

for (String line : execResult.lines) {
if (line.contains("MachineGuid")) {
String[] parts = line.trim().split("\\s+");
if (parts.length == 3) {
return Resource.create(Attributes.of(HOST_ID, parts[2]));
}
}
}
logger.warning(
"Failed to read Windows registry: No MachineGuid found in output: " + execResult.lines);
return Resource.empty();
} catch (RuntimeException e) {
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
logger.log(Level.WARNING, "Failed to read Windows registry", e);
return Resource.empty();
}
}

private static ExecResult queryWindowsRegistry() {
try {
Process process = Runtime.getRuntime().exec(REGISTRY_QUERY);
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved

if (process.waitFor() != 0) {
return new ExecResult(process.exitValue(), getLines(process.getErrorStream()));
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
}

return new ExecResult(0, getLines(process.getInputStream()));
} catch (IOException | InterruptedException e) {
throw new IllegalStateException(e);
}
}

private static List<String> getLines(InputStream inputStream) {
return new BufferedReader(new InputStreamReader(inputStream, StandardCharsets.UTF_8))
.lines()
.collect(Collectors.toList());
}

@Override
public boolean shouldApply(ConfigProperties config, Resource existing) {
return !config.getMap("otel.resource.attributes").containsKey(HOST_ID.getKey())
&& existing.getAttribute(HOST_ID) == null;
}

@Override
public int order() {
// Run after cloud provider resource providers
return Integer.MAX_VALUE - 1;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.instrumentation.resources;

import static org.assertj.core.api.Assertions.assertThat;

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
import io.opentelemetry.sdk.resources.Resource;
import java.nio.file.Path;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.assertj.core.api.MapAssert;
import org.junit.jupiter.api.DynamicTest;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestFactory;

class HostIdResourceProviderTest {

private static class LinuxTestCase {
private final String name;
private final String expectedValue;
private final Function<Path, List<String>> pathReader;

private LinuxTestCase(
String name, String expectedValue, Function<Path, List<String>> pathReader) {
this.name = name;
this.expectedValue = expectedValue;
this.pathReader = pathReader;
}
}

private static class WindowsTestCase {
private final String name;
private final String expectedValue;
private final Supplier<HostIdResourceProvider.ExecResult> queryWindowsRegistry;

private WindowsTestCase(
String name,
String expectedValue,
Supplier<HostIdResourceProvider.ExecResult> queryWindowsRegistry) {
this.name = name;
this.expectedValue = expectedValue;
this.queryWindowsRegistry = queryWindowsRegistry;
}
}

@TestFactory
Collection<DynamicTest> createResourceLinux() {
return Stream.of(
new LinuxTestCase("default", "test", path -> Collections.singletonList("test")),
new LinuxTestCase("empty file", null, path -> Collections.emptyList()),
new LinuxTestCase(
"error reading",
null,
path -> {
throw new IllegalStateException("can't read file");
}))
.map(
testCase ->
DynamicTest.dynamicTest(
testCase.name,
() -> {
HostIdResourceProvider provider =
new HostIdResourceProvider(
() -> HostIdResourceProvider.OsType.LINUX, testCase.pathReader, null);

assertHostId(testCase.expectedValue, provider);
}))
.collect(Collectors.toList());
}

@TestFactory
Collection<DynamicTest> createResourceWindows() {
return Stream.of(
new WindowsTestCase(
"default",
"test",
() ->
new HostIdResourceProvider.ExecResult(
0,
Arrays.asList(
"HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Cryptography",
" MachineGuid REG_SZ test"))),
new WindowsTestCase(
"error code",
null,
() -> new HostIdResourceProvider.ExecResult(1, Collections.emptyList())),
new WindowsTestCase(
"short output",
null,
() -> new HostIdResourceProvider.ExecResult(0, Collections.emptyList())))
.map(
testCase ->
DynamicTest.dynamicTest(
testCase.name,
() -> {
HostIdResourceProvider provider =
new HostIdResourceProvider(
() -> HostIdResourceProvider.OsType.WINDOWS,
null,
testCase.queryWindowsRegistry);

assertHostId(testCase.expectedValue, provider);
}))
.collect(Collectors.toList());
}

private static void assertHostId(String expectedValue, HostIdResourceProvider provider) {
MapAssert<AttributeKey<?>, Object> that =
assertThat(provider.createResource(null).getAttributes().asMap());

if (expectedValue == null) {
that.isEmpty();
} else {
that.containsEntry(HostIdResourceProvider.HOST_ID, expectedValue);
}
}

@Test
void shouldApply() {
HostIdResourceProvider provider = new HostIdResourceProvider();
assertThat(
provider.shouldApply(
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
Resource.getDefault()))
.isTrue();
assertThat(
provider.shouldApply(
DefaultConfigProperties.createFromMap(
Collections.singletonMap("otel.resource.attributes", "host.id=foo")),
null))
.isFalse();
}
}
Loading