package cloud resource in javaagent - but keep them disabled by default #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Mar 5, 2024
laurit
reviewed
Mar 5, 2024
laurit
reviewed
Mar 5, 2024
laurit
reviewed
Mar 5, 2024
...ain/java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 5, 2024
...ain/java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 5, 2024
There was a problem hiding this comment.
I also created a PR to add the aws detectors a while back #7927 That one has a test that verifies that aws provider runs after ContainerResourceProvider could you check whether it would make sense to bring that test over to this PR.
1 task
zeitlinger
force-pushed
the
add-cloud-resource-providers-disabled-by-default
branch
from
84b9a51
to
7f4bd5e
Compare
zeitlinger
commented
Mar 5, 2024
.github/renovate.json5
Outdated
| // Renovate's default behavior is only to update from unstable -> unstable if it's for the | ||
| // major.minor.patch, under the assumption that you would want to update to the stable version | ||
| // of that release instead of the unstable version for a future release | ||
| // (TODO remove once the artifacts above release stable versions) | ||
| "ignoreUnstable": false | ||
| "matchCurrentVersion": "/^.*-alpha$/", |
There was a problem hiding this comment.
There was a problem hiding this comment.
extracted to standalone PR: #10761
There was a problem hiding this comment.
as this part is already in a separate PR it might be best to remove it from this PR.
zeitlinger
force-pushed
the
add-cloud-resource-providers-disabled-by-default
branch
from
4da18f8
to
bca96f1
Compare
laurit
reviewed
Mar 5, 2024
...ain/java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 5, 2024
...ain/java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 5, 2024
...java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizerTest.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
add-cloud-resource-providers-disabled-by-default
branch
from
602ee35
to
f412cae
Compare
github-actions
bot
added
the
test native
laurit
reviewed
Mar 11, 2024
...ain/java/io/opentelemetry/javaagent/tooling/config/ResourceProviderPropertiesCustomizer.java
Outdated
Show resolved
Hide resolved
5 tasks
laurit
approved these changes
Mar 11, 2024
trask
reviewed
Mar 11, 2024
zeitlinger
force-pushed
the
add-cloud-resource-providers-disabled-by-default
branch
from
b68105d
to
0bb07e8
Compare
|
zeitlinger
force-pushed
the
add-cloud-resource-providers-disabled-by-default
branch
from
0bb07e8
to
694ab74
Compare
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins can be enabled or disabled using
otel.resource.providers.<>.enabled, e.g.otel.resource.providers.aws.enabledFixes #10447