Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container.id issue in some crio scenarios #11382

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix container.id issue in some crio scenarios #11382

merged 1 commit into from
May 20, 2024

Conversation

liurui-1
Copy link

@liurui-1 liurui-1 commented May 17, 2024 •
edited
Loading

I find that the previous algorism to detect container.id resource attribute does not work for some crio scenarios. I improved the logic and added one test case.

@liurui-1 liurui-1 requested a review from a team May 17, 2024 02:17
@laurit laurit merged commit bfb1a64 into open-telemetry:main May 20, 2024
53 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@opentelemetrybot
Fix container.id issue in some crio scenarios (#11382)
46e7898
@opentelemetrybot opentelemetrybot mentioned this pull request May 20, 2024
Merged
@liurui-1 liurui-1 mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liurui-1 @laurit