Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Sdk 0.16.0 #2221

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Update to Sdk 0.16.0 #2221

merged 6 commits into from
Feb 9, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Feb 8, 2021 •
edited
Loading

No more breaking changes so using unversioned SNAPSHOT should be OK.

@anuraaga
Copy link
Contributor Author

anuraaga commented Feb 8, 2021

Hmm - maybe unversioned snapshot isn't a good idea after all. AFAICT, it seems to trigger some flakiness when muzzling, this error message doesn't seem valid (I can click through to the links it says are missing)

A problem occurred configuring project ':instrumentation:cdi-testing'.
> Could not resolve all files for configuration ':instrumentation:cdi-testing:toolingRuntime'.
   > Could not find io.opentelemetry:opentelemetry-api:0.16.0-SNAPSHOT.
     Searched in the following locations:
       - file:/home/runner/.m2/repository/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/maven-metadata.xml
       - file:/home/runner/.m2/repository/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/opentelemetry-api-0.16.0-SNAPSHOT.pom
       - https://repo.maven.apache.org/maven2/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/opentelemetry-api-0.16.0-SNAPSHOT.pom
       - https://jcenter.bintray.com/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/maven-metadata.xml
       - https://jcenter.bintray.com/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/opentelemetry-api-0.16.0-SNAPSHOT.pom
       - https://repo.typesafe.com/typesafe/releases/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/maven-metadata.xml
       - https://repo.typesafe.com/typesafe/releases/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/opentelemetry-api-0.16.0-SNAPSHOT.pom
       - https://oss.sonatype.org/content/repositories/snapshots/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/maven-metadata.xml
       - https://oss.sonatype.org/content/repositories/snapshots/io/opentelemetry/opentelemetry-api/0.16.0-SNAPSHOT/opentelemetry-api-0.16.0-20210208.093215-85.pom
     Required by:
         project :instrumentation:cdi-testing > project :javaagent-tooling
         project :instrumentation:cdi-testing > project :javaagent-tooling > project :javaagent-bootstrap
         project :instrumentation:cdi-testing > project :javaagent-tooling > project :javaagent-api
         project :instrumentation:cdi-testing > project :javaagent-tooling > project :instrumentation-api
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-api-metrics:0.16.0-alpha-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-sdk:0.16.0-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-extension-kotlin:0.16.0-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-extension-trace-propagators:0.16.0-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > project :instrumentation-api > io.opentelemetry:opentelemetry-semconv:0.16.0-alpha-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-sdk:0.16.0-SNAPSHOT:20210208.093215-85 > io.opentelemetry:opentelemetry-sdk-common:0.16.0-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-sdk:0.16.0-SNAPSHOT:20210208.093215-85 > io.opentelemetry:opentelemetry-sdk-trace:0.16.0-SNAPSHOT:20210208.093215-85
         project :instrumentation:cdi-testing > project :javaagent-tooling > io.opentelemetry:opentelemetry-exporter-jaeger:0.16.0-SNAPSHOT:20210208.093215-85 > io.opentelemetry:opentelemetry-sdk-extension-otproto:0.16.0-SNAPSHOT:20210208.093215-85

@anuraaga anuraaga changed the title Update to Sdk 0.16.0 snapshot Update to Sdk 0.16.0 Feb 9, 2021
@anuraaga
Copy link
Contributor Author

anuraaga commented Feb 9, 2021

Updated to target released 0.16.0

trask
trask approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ for keeping us up-to-date over the past several months of API and SDK changes

...a-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/LambdaUtils.java Show resolved Hide resolved
...y/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestApiGatewayWrapperTest.groovy Show resolved Hide resolved
examples/distro/instrumentation/build.gradle
relocate "io.opentelemetry.extension.kotlin", "io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.kotlin"
relocate "io.opentelemetry.extension.trace.propagation", "io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.trace.propagation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this for b3, jaeger, and ottrace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't directly use any in our instrumentation so I think it's ok not to shade them (they're only in the agent classloader, never injected into the user). Maybe it's confusing though let me know if we should just shade for the heck of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg it's so confusing 😭, but let's not shade for the heck of it, that just masks the confusion of what's going on, I'll try to write a better comment for these relocation blocks tomorrow, let's merge this(!)

gradle/instrumentation.gradle Show resolved Hide resolved
@anuraaga anuraaga merged commit fc41070 into open-telemetry:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@trask trask trask approved these changes

@iNikem iNikem iNikem approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anuraaga @trask @iNikem @mateuszrzeszutek