Add support for elasticsearch7 #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
LGTM 👍
Just wondering, what about the elasticsearch-rest-6.4 instrumentation?
It has this suspicious TODO, maybe similar test there changes will make it work?
// TODO: The tests are incompatible with 7.x. The instrumentation may be as well.
latestDepTestImplementation group: 'org.elasticsearch.client', name: 'elasticsearch-rest-client', version: '6.+'
|
I did look at it and while tests can be made to work the instrumentation also needs a bit of work because of elastic/elasticsearch@a7046e0 Previously request methods ended up in |
anuraaga
approved these changes
Mar 7, 2021
| takesArgument( | ||
| 0, | ||
| namedOneOf( | ||
| "org.elasticsearch.action.Action", |
There was a problem hiding this comment.
This sort of change happened on minor version 6.5? Geez
iNikem
approved these changes
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak elasticsearch test and instrumentation a bit so it would work for versions starting from 6.5