Concurrent http client tests with connection reuse #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Mar 15, 2021
instrumentation/vertx-web-3.0/src/test/groovy/client/VertxSingleConnection.java
Show resolved
Hide resolved
...java/io/opentelemetry/javaagent/instrumentation/vertx/client/HttpRequestInstrumentation.java
Show resolved
Hide resolved
anuraaga
approved these changes
Mar 16, 2021
mateuszrzeszutek
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this PR introduces a new kind of test in
HttpClientTest. It is very similar to the already existing high concurrency test, but all requests use the same single connection.Second, I implement this test for Vert.x, which requires some additional instrumentations. The main one is that we now actually starting http client span on Vert.x API boundary, not on the underlying Netty. See #2496 for my rant about this.
Third, I had to disable a couple of tests in Reactive Vert.x. They started to fail because Netty does not produce spans anymore (see point 2 above) and thus does not scope response processing. I think the correct way to fix this is to use RxJava integration that we have. It's strange that vertx-rxjava integration does not use rxjava integration 🤔