Camel instrumentation - SNS propagation impl + tests #2562
Conversation
ghost
commented
Mar 11, 2021
ghost
commented
- fixes issues with SNS to SQS propagation for Apache Camel instr
- added tests (currently ignored - work only with live AWS)
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
...t/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/SnsCamelTest.groovy
Show resolved
Hide resolved
| trace(6, 3) { | ||
| span(0) { | ||
| name "SNS.Publish" | ||
| kind CLIENT |
There was a problem hiding this comment.
This is a tough question.
In general, SNS message can be fan out to SQS (becoming a message), HTTP, lambda, kinesis or even email. In some of these cases we would have PUBLISH (send) - CLIENT (get) while now for SQS we have CLIENT (send) - CONSUMER (get).
If we could, the best way IMO would be to modify "sending" span kind once a message is consumed (by SQS), but we can't.
@anuraaga what do you think?
There was a problem hiding this comment.
From what I understand of the spec, we'd still generally expect the SNS message to be treated like messaging conventions so would be PRODUCER. The trickiness related to CLIENT and PRODUCER has come up before, I'm ok with just picking any for now but good chance of changing later.
...gent/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/SnsConfig.groovy
Outdated
Show resolved
Hide resolved
...t/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/SnsCamelTest.groovy
Show resolved
Hide resolved
...t/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/SnsCamelTest.groovy
Outdated
Show resolved
Hide resolved
|
@kubawach Please rebase again. Main branch failure was fixed |
