Add support for GWT #2652
Merged
Add support for GWT #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Mar 29, 2021
mateuszrzeszutek
approved these changes
Mar 29, 2021
...wt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/GwtTracer.java
Outdated
Show resolved
Hide resolved
Comment on lines
61
to
64
| .and(takesArgument(0, named(Object.class.getName()))) | ||
| .and(takesArgument(1, named(Method.class.getName()))) | ||
| .and(takesArgument(3, named("com.google.gwt.user.server.rpc.SerializationPolicy"))) | ||
| .and(takesArgument(4, named(int.class.getName()))), |
There was a problem hiding this comment.
There's no need for named() matcher when referencing standard Java types:
Suggested change
| .and(takesArgument(0, named(Object.class.getName()))) | |
| .and(takesArgument(1, named(Method.class.getName()))) | |
| .and(takesArgument(3, named("com.google.gwt.user.server.rpc.SerializationPolicy"))) | |
| .and(takesArgument(4, named(int.class.getName()))), | |
| .and(takesArgument(0, Object.class)) | |
| .and(takesArgument(1, Method.class)) | |
| .and(takesArgument(3, named("com.google.gwt.user.server.rpc.SerializationPolicy"))) | |
| .and(takesArgument(4, int.class)), |
There was a problem hiding this comment.
Thanks, didn't know that. Should be fixed now.
mateuszrzeszutek
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add span around java method called from javascript.