Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Jdk8AsyncEndStrategy to Jdk8AsyncSpanEndStrategy #2664

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Rename Jdk8AsyncEndStrategy to Jdk8AsyncSpanEndStrategy #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e95e0
Rename Jdk8AsyncEndStrategy to Jdk8AsyncSpanEndStrategy
HaloFour Mar 30, 2021
4d17c45
Merge remote-tracking branch 'upstream/main' into rename-jdk8-async-s…
trask Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/java/io/opentelemetry/instrumentation/api/tracer/async/AsyncSpanEndStrategies.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static AsyncSpanEndStrategies getInstance() {
private final List<AsyncSpanEndStrategy> strategies = new CopyOnWriteArrayList<>();

private AsyncSpanEndStrategies() {
strategies.add(Jdk8AsyncEndStrategy.INSTANCE);
strategies.add(Jdk8AsyncSpanEndStrategy.INSTANCE);
}

public void registerStrategy(AsyncSpanEndStrategy strategy) {
Expand Down
2 changes: 1 addition & 1 deletion ...pi/tracer/async/Jdk8AsyncEndStrategy.java → ...racer/async/Jdk8AsyncSpanEndStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;

enum Jdk8AsyncEndStrategy implements AsyncSpanEndStrategy {
enum Jdk8AsyncSpanEndStrategy implements AsyncSpanEndStrategy {
INSTANCE;

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...racer/async/Jdk8MethodStrategyTest.groovy → ...async/Jdk8AsyncSpanEndStrategyTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ import spock.lang.Specification
import java.util.concurrent.CompletableFuture
import java.util.concurrent.CompletionException

class Jdk8MethodStrategyTest extends Specification {
class Jdk8AsyncSpanEndStrategyTest extends Specification {
BaseTracer tracer

Context context

def underTest = Jdk8AsyncEndStrategy.INSTANCE
def underTest = Jdk8AsyncSpanEndStrategy.INSTANCE

void setup() {
tracer = Mock()
Expand Down