Muzzle should check whether used fields are declared somewhere #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
laurit
reviewed
Apr 27, 2021
| @Override | ||
| public Stream<Field> getFields() { | ||
| return reference.getFields().stream() | ||
| .filter(this::isDeclaredAndNotPrivate) |
There was a problem hiding this comment.
Why are private fields special? An optimization? Nestmates can access private fields within nest, would that be an issue?
There was a problem hiding this comment.
It's an optimization. This field check is mostly meant to detect changed/renamed fields when we're extending library classes - nested classes are not a valid scenario in this case. And if we use nested classes in our own instrumentation code the Java compiler will pick up all inconsistencies.
laurit
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2823