Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to colon notation for dependencies. #2994

Merged
merged 3 commits into from
May 15, 2021
Merged

Switch to colon notation for dependencies. #2994

merged 3 commits into from
May 15, 2021

Conversation

anuraaga
Copy link
Contributor

  • Less verbose
  • Format provided by search.maven.org and official docs in most places I've seen
  • Consistent with opentelemetry-java

mateuszrzeszutek
mateuszrzeszutek approved these changes May 14, 2021
View reviewed changes
examples/distro/build.gradle Outdated
Comment on lines 23 to 25
dependencies.create("com.google.auto.service:auto-service:1.0-rc7"),
dependencies.create("com.google.auto:auto-common:0.8"),
dependencies.create("com.google.guava:guava:${versions.guava}"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think that we don't need to call dependencies.create() anymore, we can just pass the string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks!

mateuszrzeszutek
mateuszrzeszutek reviewed May 14, 2021
View reviewed changes
buildSrc/src/main/groovy/MuzzlePlugin.groovy Outdated
@@ -324,7 +324,7 @@ class MuzzlePlugin implements Plugin<Project> {
def config = instrumentationProject.configurations.create(taskName)

if (!muzzleDirective.coreJdk) {
def dep = instrumentationProject.dependencies.create("$versionArtifact.groupId:$versionArtifact.artifactId:$versionArtifact.version") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you probably need those in this file 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes bad regex :)

@anuraaga anuraaga merged commit fe41885 into open-telemetry:main May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraaga @iNikem @mateuszrzeszutek