Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate context to armeria callbacks #3108

Merged
merged 2 commits into from
May 28, 2021
Merged

Propagate context to armeria callbacks #3108

merged 2 commits into from
May 28, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 27, 2021

Resolves #3049

anuraaga
anuraaga approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will eventually add proper context bridge but this seems good to fix build for now.

@trask trask merged commit 32e28c1 into open-telemetry:main May 28, 2021
robododge pushed a commit to robododge/opentelemetry-java-instrumentation that referenced this pull request Jun 17, 2021
@laurit @robododge
Propagate context to armeria callbacks (open-telemetry#3108)
7953778
@laurit laurit deleted the armeria-context-propagation branch August 17, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test ArmeriaHttpClientTest trace request with callback and parent
4 participants
@laurit @anuraaga @mateuszrzeszutek @trask