Embedded extension #3237
Embedded extension #3237
Conversation
iNikem
requested review from
anuraaga,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionLoader.java
Outdated
Show resolved
Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionLoader.java
Outdated
Show resolved
Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionLoader.java
Outdated
Show resolved
Hide resolved
We don't run examples' tests on CI. So only locally. Will file |
|
@iNikem I didn't confirm the fake backend image referenced in the examples smoketest is new enough for it, but we changed the path to |
Yes, that's it! Thank you! Fixed now. |
| @@ -86,8 +136,13 @@ private static void addFileUrl(List<URL> result, File file) { | |||
| } | |||
| } | |||
|
|
|||
| private static URLClassLoader getDelegate(ClassLoader parent, URL extensionUrl) { | |||
| return new ExtensionClassLoader(new URL[] {extensionUrl}, parent); | |||
| private static void extractFile(JarFile jarFile, JarEntry jarEntry, File outputFile) | |||
There was a problem hiding this comment.
outputDir since we're extracting a jar?
There was a problem hiding this comment.
No, that parameter is actually a file
There was a problem hiding this comment.
Oh oops - so the output file is a JAR file itself. extractFile made me think the embedded JAR itself is getting extracted into its contents. I don't think unpackFile had the same impression for me so may be a clearer name for people like me
There was a problem hiding this comment.
We extract a file from jarEntry into an outputFile. Like "extract a file from a jar". How can this translate to a double extraction? :) But I can rename if you wish, no problem
There was a problem hiding this comment.
There's two "Jar" variables there :) My brain processed it as extracting the second one. Maybe it's silly, so don't mind either way
There was a problem hiding this comment.
Is there any possibility to read directly from the embedded jar? Otherwise we limit possibility to run on read-only file system, a request we've gotten, and @tylerbenson has mentioned previously that they support.
I did not find it on the first try. But I don't think this is an actual blocker: on read-only system one can use external extensions jar. I can file a follow-up issue for that. |
|
FWIW, spring-boot has been extracting embedded JARs to file system for a loong time so it's tried and true :) |
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionClassLoader.java
Outdated
Show resolved
Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionClassLoader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
| File javaagentFile = installBootstrapJar(inst); | ||
| AgentInitializer.initialize(inst, javaagentFile); |
| constructor.newInstance(bootstrapUrl, innerJarFilename, agentParent); | ||
| new AgentClassLoader(javaagentFile, innerJarFilename, agentParent); |
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Builds on top of #3226 allowing to embed extension jar right inside javaagent jar for simplified deployment.
@anuraaga can you take a look at
examples/extension/src/test/java/com/example/javaagent/smoketest/SpringBootIntegrationTest.java? It often time fails for me. Looks like later tests continue receiving spans from the previous tests./clear-requestson fake backend does not work as expected or?