Refactor span names class #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Jun 14, 2021
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/ClassNames.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jun 14, 2021
| return type.getSimpleName(); | ||
| } | ||
| String className = type.getName(); | ||
| if (type.getPackage() != null) { |
There was a problem hiding this comment.
Packages are optional. Perhaps it would be better to use the same strategy as jdk uses
className = className.substring(className.lastIndexOf('.') + 1);
mateuszrzeszutek
approved these changes
Jun 14, 2021
|
|
||
| package io.opentelemetry.instrumentation.api.tracer; | ||
|
|
||
| public class ClassNames { |
There was a problem hiding this comment.
Nit: make it final and add a private constructor
| @@ -33,7 +33,7 @@ private CodeSpanNameExtractor(CodeAttributesExtractor<REQUEST, ?> attributesExtr | |||
| public String extract(REQUEST request) { | |||
| Class<?> cls = attributesExtractor.codeClass(request); | |||
| // TODO: avoid using SpanNames, encapsulate the logic here | |||
There was a problem hiding this comment.
I guess we can remove this TODO
mateuszrzeszutek
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in this PR:
BaseTracer.spanName*methodsClassNamesfromSpanNamesSpanNames.spanNameForMethod-->SpanNames.fromMethodSpanNames.spanNameForClass-->ClassNames.simpleNameBased on @anuraaga's #3070 (comment):