Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vaadin latest dep test #3785

Closed
wants to merge 1 commit into from

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Aug 6, 2021

Resolves #3782
Resolves #3781 (this one has one more failure, but it seems like a one time occurrence)

Comment on lines +18 to +20
* This advice is used only when running tests. Works around an issue running testLatestDeps.
* Currently the latest vaadin release is 20, it is likely that this advice can be deleted when
* there is a new version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add to this comment explaining this problem only affects our tests, and is not a problem for end users?

Copy link
Contributor Author

@laurit laurit Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that it is a problem for at least some users GoogleChrome/workbox#2904 Our test isn't exactly a regular vaadin application. We let vaadin development mode generate a bunch of files each time test is first run after clean that regular users would add to version control. I suspect that the javascript tooling used probably doesn't attempt to find new package versions on each run so if they set up their project before yesterday this is yet to break for them (this is speculation). If it breaks they probably know how to pin package to working version. I also initially tried to make it use the previous working version of workbox-build but failed at it. I guess should have use pnpm-lock.yaml to pin version. So after failing with javascript tooling I turned to what I know, patching java code. As an alternative we could find the latest working vaadin version (something that uses workbox-webpack-plugin before 6.x?) and make latest dep tests use that until vaadin switches to workbox-webpack-plugin 6.2.
Edited: there is also a vaadin issue for this vaadin/flow#11524

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative we could find the latest working vaadin version (something that uses workbox-webpack-plugin before 6.x?) and make latest dep tests use that until vaadin switches to workbox-webpack-plugin 6.2.

I think this would be my preference

@laurit laurit closed this Aug 6, 2021
@laurit laurit deleted the vaadin-latest-dep branch August 24, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly build Nightly build
2 participants