Bridge trace builder #4090
Merged
Bridge trace builder #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Sep 10, 2021
| testImplementation(project(":instrumentation:opentelemetry-api-1.0:testing")) | ||
| testInstrumentation(project(":instrumentation:opentelemetry-api-1.0:testing")) | ||
| testImplementation(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.0:testing")) | ||
| testInstrumentation(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.0:testing")) |
There was a problem hiding this comment.
unrelated to this PR but
Suggested change
| testInstrumentation(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.0:testing")) |
There was a problem hiding this comment.
ignore me, meant to delete this comment (because it's wrong 😄)
...pentelemetry/javaagent/instrumentation/opentelemetryapi/trace/ApplicationTracerProvider.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Sep 13, 2021
| io.opentelemetry.api.trace.TracerProvider agentTracerProvider) { | ||
| if (TRACE_PROVIDER_14 != null) { | ||
| try { | ||
| return (TracerProvider) TRACE_PROVIDER_14.newInstance(agentTracerProvider); |
There was a problem hiding this comment.
Can we use a MethodHandle instead of reflection?
…ent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetryapi/trace/ApplicationTracerProvider.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
laurit
force-pushed
the
bridge-trace-builder
branch
from
e935614 to
f204bad
Compare
mateuszrzeszutek
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4015
Introduce a separate module for bridging 1.4 api because
TracerBuilderwas added in 1.4.