Extract net attributes both on start and on end in netty HTTP client #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Oct 19, 2021
trask
reviewed
Oct 20, 2021
...ntelemetry/javaagent/instrumentation/netty/common/client/NettyClientInstrumenterFactory.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
netty-client-capture-net-attributes-on-both
branch
from
d7396f8 to
9afde26
Compare
laurit
approved these changes
Oct 20, 2021
trask
reviewed
Oct 20, 2021
...lemetry/javaagent/instrumentation/netty/common/client/NettyNetClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
…o/opentelemetry/javaagent/instrumentation/netty/common/client/NettyNetClientAttributesExtractor.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
mateuszrzeszutek
deleted the
netty-client-capture-net-attributes-on-both
branch
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…pen-telemetry#4420) * Extract net attributes both on start and on end in netty HTTP client * storing remote address in HttpRequestAndChannel * Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/client/NettyNetClientAttributesExtractor.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4408 - on the SIG meeting today we've decided to just extract those attributes both on start and end and stay with the current naming scheme.