Context propagation for undertow async dispatch #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
laurit
commented
Dec 20, 2021
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static PropagatedContext enterJobSubmit( | ||
| @Advice.Argument(value = 1, readOnly = false) Runnable task) { | ||
| Context context = Java8BytecodeBridge.currentContext(); |
There was a problem hiding this comment.
Alternatively could wrap the Runnable and handle restoring context there
mateuszrzeszutek
approved these changes
Dec 21, 2021
trask
approved these changes
Dec 21, 2021
| import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.REDIRECT | ||
| import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.SUCCESS | ||
|
|
||
| class UndertowServerDispatchTest extends HttpServerTest<Undertow> implements AgentTestTrait { |
|
Hi @mateuszrzeszutek @trask, |
|
hey @lokeshcse6! the current plan is for OpenTelemetry Java SDK 1.10.0 release at the end of this week and OpenTelemetry Java Instrumentation 1.10.0 at the end of next week. |
|
Hi @trask |
|
@lokeshcse6 are you looking for snapshot builds? |
@trask Yes that is correct tested with snapshot jar fix is working fine. Thanks for help!!! |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4897