Always set parent of agent class loader to bootstrap class loader #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jan 18, 2022
| public static boolean isJavaBefore9() { | ||
| return System.getProperty("java.version").startsWith("1."); | ||
| private static ClassLoader createAgentClassLoader(String innerJarFilename, File javaagentFile) { | ||
| return new AgentClassLoader(javaagentFile, innerJarFilename, null); |
There was a problem hiding this comment.
any reason to keep the parent argument in the constructor?
laurit
force-pushed
the
null-parent-loader
branch
from
f9ece06 to
56f62b5
Compare
anuraaga
approved these changes
Jan 19, 2022
| agentParent = null; // bootstrap | ||
| } else { | ||
| // platform classloader is parent of system in java 9+ | ||
| agentParent = getPlatformClassLoader(); |
There was a problem hiding this comment.
Any idea why we were doing this before?
There was a problem hiding this comment.
this was inherited, my best guess is for access to java.sql package for some reason(?)
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…en-telemetry#5169) * Always set parent of agent class loader to bootstrap class loader * remove parent class loader argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5156