Add prometheus smoke test #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Feb 21, 2022
| TargetWaitStrategy waitStrategy, | ||
| String[] cmd) { | ||
| if (extraPorts != null && !extraPorts.isEmpty()) { | ||
| throw new UnsupportedOperationException("extra ports not supported"); |
There was a problem hiding this comment.
what was the issue with passing it to withExposedPorts() below?
There was a problem hiding this comment.
There is also the withPortBindings part. I don't have an easy way to test on windows so I chose to leave it unimplemented instead of adding something that might not work. This test doesn't run on windows anyway.
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4516