More release automation #5419
More release automation #5419
Conversation
|
|
||
| - name: Bump download link version | ||
| run: | | ||
| sed -Ei "s,https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v[0-9]+.[0-9]+.[0-9]+/,https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v${{ needs.release.outputs.release-version }}/," README.md |
There was a problem hiding this comment.
Was wondering whether for main branch it doesn't make sense to just use latest
There was a problem hiding this comment.
I think that makes sense, it does revert the decision in #4774, but we've recently decided that main docs reflect SNAPSHOT state anyways (for some reason those things connect for me, even though I'm not sure they really do)
|
@mateuszrzeszutek is your approval a vote to stay with versioned download link on |
|
I think it makes slightly more sense to have versioned links -- READMEs on release branches and tags (that stem out from |
|
oh, I was not clear, @anuraaga's proposal is to keep versioned links on the tags, only using |
|
Oh, so we'll replace the latest link with versioned link when the branch is cut? In that case, using |
|
Closing, will send new PR to change to |
No description provided.