Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a comma separated list of extensions #6137

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Allow specifying a comma separated list of extensions #6137

merged 4 commits into from
Jun 8, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jun 3, 2022

No description provided.

@laurit laurit requested a review from a team June 3, 2022 11:31
@laurit
Copy link
Contributor Author

laurit commented Jun 6, 2022

@trask I forgot to add the doc change in the first commit, could you check whether it is ok

trask
trask approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if my suggestion is better or not...

examples/extension/README.md Outdated Show resolved Hide resolved
@laurit @trask
Update examples/extension/README.md
e156f75 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@laurit laurit merged commit 091197a into open-telemetry:main Jun 8, 2022
@laurit laurit deleted the multiple-extensions branch June 8, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurit @trask