Rocketmq 5: set context for async callback #7238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
reviewed
Nov 19, 2022
Comment on lines
+103
to
+105
| if (consumer != null) { | ||
| // Not calling consumer.close(); because it takes a lot of time to complete |
There was a problem hiding this comment.
the built-in threadpools don't shutdown if consumer#close is not called, or could we submit an async task to close consumer here?
Comment on lines
+58
to
+64
|
|
||
| transformer.applyAdviceToMethod( | ||
| isMethod() | ||
| .and(named("sendAsync")) | ||
| .and(takesArguments(1)) | ||
| .and(takesArgument(0, named("org.apache.rocketmq.client.apis.message.Message"))), | ||
| ProducerImplInstrumentation.class.getName() + "$SendAsyncAdvice"); |
There was a problem hiding this comment.
Nice catch for Producer#sendAsync👍🏻
aaron-ai
approved these changes
Nov 21, 2022
mateuszrzeszutek
approved these changes
Nov 21, 2022
...in/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java
Show resolved
Hide resolved
laurit
force-pushed
the
rocketmq-async-callback
branch
from
f47393b
to
79c8d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run callbacks added to the
CompletableFuturereturned fromsendAsyncwith the context that was used whensendAsyncwas called.Add test for capturing message headers.