Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End netty client span when channel is closed #8605

Merged
merged 1 commit into from
Jun 1, 2023
Merged

End netty client span when channel is closed #8605

merged 1 commit into from
Jun 1, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 30, 2023

Resolves #8598
Should we set the span status to ERROR when it is ended because the channel was closed?

@laurit laurit requested a review from a team May 30, 2023 17:33
@mateuszrzeszutek
Copy link
Member

Should we set the span status to ERROR when it is ended because the channel was closed?

I don't think we should - we can't really know the intention of the user who closed the channel early, it might've been intentional and not necessarily an error situation.

@laurit laurit merged commit c4d4bf8 into open-telemetry:main Jun 1, 2023
@laurit laurit deleted the netty-channel-close branch June 1, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The End method of Span appears to have not been invoked, resulting in the Span not being uploaded.
2 participants
@laurit @mateuszrzeszutek