Ability to instrument logs before OTel injection into OTel appenders

[jeanbisutti]

The logs created before the injection of the OpenTelemetry instance into the OpenTelemetry appenders were not instrumented.

[jeanbisutti]

For Log4j, LogEvent has String getThreadName() and long getThreadId() methods. Maybe they coud be used in the LogEventMapper:

opentelemetry-java-instrumentation/instrumentation/log4j/log4j-appender-2.17/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/internal/LogEventMapper.java

Line 110 in 1c6776f

attributes.put(SemanticAttributes.THREAD_NAME, currentThread.getName());

In this way, for cached logs, we could be sure to have the good thread name and thread values, for example in the case of an OTel injection not done from the main thread.

[jeanbisutti]

A Logback ILoggingEvent object, has only a String getThreadName() method, not a long getThreadId method. Perhaps the current implementation to get the thread name and thread id could be kept:

opentelemetry-java-instrumentation/instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java

Line 122 in 086cddd

attributes.put(SemanticAttributes.THREAD_NAME, currentThread.getName());

In addition we could document for Logback that the cached logs could have a wrong thread name and thread id?

[trask]

In addition we could document for Logback that the cached logs could have a wrong thread name and thread id?

I think I'd prefer the extra code to implement correct behavior and not need to remember about (or document) this edge case not working.

[jeanbisutti]

Thread id and thread name are fixed for the replayed logs

[jeanbisutti]

it seems like we pretty much need to run the full set of tests using both pre-install path and post-install path (since it would be easy to miss one of the pieces of opt-in data, and easy in the future to add a new opt-in data and forget to handle the pre-install path)

can we make this a base test class and have two subclasses, one which does install before the test, and one that delays the install?

tests refactored