-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic release support #1024
Conversation
@carlosalberto could we have In jaeger java client (gradle based) we have fully automated release from travis to maven central. It's done by pushing a release tag. The artifact version is kept in https://github.com/jaegertracing/jaeger-client-java/blob/master/RELEASE.md#automatic-release-preferred https://github.com/jaegertracing/jaeger-client-java/blob/master/travis/deploy.sh |
@pavolloffay Great idea, lets definitely do that. A local command is also available at this moment, so I will include the explanation in such document (however, user will have to provide his/her credentials, but I guess that's taken for granted). I will do a follow-up on the more-automated part after we get this one merged ;) |
@pavolloffay Added a small |
@open-telemetry/java-approvers Please review/approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release should be also marked on Github and probably with copied the changelog for that version.
Sure, we can do that when doing the fully automatized version (that is, right after 0.3.0 and definitely before 1.0) |
I mean it should be documented to do that, I am not sure if there is gradle tooling that can update the changelog on Github. |
Updated. @bogdandrutu Verify and merge. |
* Initial support for automatic artifacts release. * Try out version 0.2.4 * Use 1GB ram as the build task. * Restore original version. * Add RELEASE.md * Minor style fixes. * Fixes.
Fixes #971
We still need to manually update the
version
field inbuild.gradle
, but once that is done, creating a branch starting withv.
triggers a deployment to Bintray/Maven Central.See https://github.com/open-telemetry/opentelemetry-java/releases/tag/v0.2.4 as an example (I used this one to verify all works great).
In a future we can play with plugins that automatically update the version and create a tag (such as the Maven Release plugin does).
PS - I'd like to stop repeating all the steps in the different tasks if possible (now we have very similar
build
,java11
andrelease
tasks). But we need somebody who is a Circle wizard or one who digs enough into this. Anyway, something to do in the future.