Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration class for BatchSpanProcessor #1080

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Configuration class for BatchSpanProcessor #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5671f56
Add config class for BatchSpanProcessor
thisthat Apr 6, 2020
9982c8f
Implement Configuration for BatchSpanProcessor
thisthat Apr 14, 2020
67a4741
goJF after rebase
thisthat Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ subprojects {
junit : 'junit:junit:4.12',
mockito : 'org.mockito:mockito-core:2.28.2',
truth : 'com.google.truth:truth:1.0.1',
system_rules : 'com.github.stefanbirkner:system-rules:1.19.0', // env and system properties
slf4jsimple : 'org.slf4j:slf4j-simple:1.7.25', // Compatibility layer
awaitility : 'org.awaitility:awaitility:3.0.0', // Compatibility layer
testcontainers : 'org.testcontainers:testcontainers:1.13.0',
Expand Down
2 changes: 1 addition & 1 deletion exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public JaegerGrpcSpanExporter build() {
* @param tracerSdkProvider tracer SDK provider
*/
public void install(TracerSdkProvider tracerSdkProvider) {
BatchSpansProcessor spansProcessor = BatchSpansProcessor.newBuilder(this.build()).build();
BatchSpansProcessor spansProcessor = BatchSpansProcessor.create(this.build());
tracerSdkProvider.addSpanProcessor(spansProcessor);
}

Expand Down
2 changes: 2 additions & 0 deletions sdk/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ dependencies {

testAnnotationProcessor libraries.auto_value

testCompile libraries.system_rules

signature "org.codehaus.mojo.signature:java17:1.0@signature"
signature "net.sf.androidscents.signature:android-api-level-24:7.0_r2@signature"
}
Expand Down
Loading