Return Span from DefaultSpan factories. #1519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1135 talks about hiding
DefaultSpan
completely. I couldn't quite find a good home for the factory methods (maybeDefaultTracer
?) but it seems like a good idea.In the meantime, it's more important to make the return type of the factories generic because users should definitely not have to care whether a span is a
DefaultSpan
or not. In practice, the return value ofDefaultSpan
makes it difficult to bridge them in auto instrumentation.open-telemetry/opentelemetry-java-instrumentation#764