Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1503 prometheus example #1541

Merged
merged 6 commits into from
Aug 17, 2020

Conversation

jarebudev
Copy link
Contributor

@jarebudev jarebudev commented Aug 16, 2020

resolves #1503

Screenshot from 2020-08-17 22-01-16

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1541   +/-   ##
=========================================
  Coverage     86.56%   86.56%           
  Complexity     1367     1367           
=========================================
  Files           162      162           
  Lines          5231     5231           
  Branches        490      490           
=========================================
  Hits           4528     4528           
  Misses          524      524           
  Partials        179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8cfd4...2d2620e. Read the comment docs.

examples/prometheus/README.md Outdated Show resolved Hide resolved
examples/prometheus/README.md Outdated Show resolved Hide resolved
examples/prometheus/README.md Show resolved Hide resolved
@jkwatson
Copy link
Contributor

Thanks for this contribution! Can you attach a screenshot of the prometheus UI from this example to the PR description?

@jkwatson
Copy link
Contributor

Sorry.. I meant to put the image in the description of the PR, so people looking at it in the future will see it front-and center in the PR itself, without having to look at comments.

@jarebudev
Copy link
Contributor Author

Sorry.. I meant to put the image in the description of the PR, so people looking at it in the future will see it front-and center in the PR itself, without having to look at comments.

haha i'll correct that! it's been a long day!

@jkwatson jkwatson merged commit a08dd9f into open-telemetry:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an example of using the Prometheus exporter
4 participants